Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes nodeCrawl with empty roots #3776

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Completes nodeCrawl with empty roots #3776

merged 1 commit into from
Jun 9, 2017

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Jun 9, 2017

Summary

This PR updates edge cases of nodeCrawl in case of empty roots are provided it never completes.

Test plan

Test coverage's added for specific cases.

@codecov-io
Copy link

Codecov Report

Merging #3776 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3776      +/-   ##
==========================================
+ Coverage   59.86%   59.88%   +0.01%     
==========================================
  Files         191      191              
  Lines        7007     7009       +2     
  Branches        6        6              
==========================================
+ Hits         4195     4197       +2     
  Misses       2809     2809              
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-haste-map/src/crawlers/node.js 95.89% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e432a...94fa559. Read the comment docs.

@cpojer cpojer merged commit f3f3473 into jestjs:master Jun 9, 2017
@cpojer
Copy link
Member

cpojer commented Jun 9, 2017

Thank you! How did you run into this edge case?

@kwonoj kwonoj deleted the short-curcuit-node-crawl branch June 9, 2017 13:03
@kwonoj
Copy link
Contributor Author

kwonoj commented Jun 9, 2017

I guess normal execution won't hit this as configuration enforces values. I caught this by some logic created runtime explicitly without full set of configuration. (danger/danger-js#224)

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants